Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add zod schemas for config.json -sample PR #14997

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: Add zod schemas for config.json -sample PR #14997

wants to merge 1 commit into from
+18 −0

Conversation

smk1993
Copy link
Contributor

@smk1993 smk1993 commented May 13, 2024

What does this PR do?

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected)
  • I have added a Docs issue here if this PR makes changes that would require a documentation change
  • I have added or modified automated tests that prove my fix is effective or that my feature works (PRs might be rejected if logical changes are not properly tested)

How should this be tested?

PR is not complete , just added sample for config json.

  • Are there environment variables that should be set?
  • What are the minimal test data to have?
  • What is expected (happy path) to have (input and output)?
  • Any other important info that could help to test that PR

@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label May 13, 2024
@graphite-app graphite-app bot requested a review from a team May 13, 2024 07:19
@vercel Vercel
Copy link

vercel bot commented May 13, 2024

@smk1993 is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added Low priority Created by Linear-GitHub Sync ⚡ Quick Wins A collection of quick wins/quick fixes that are less than 30 minutes of work ✅ good first issue Good for newcomers ✨ feature New feature or request labels May 13, 2024
@github-actions GitHub Actions
Copy link
Contributor

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

@smk1993
Copy link
Contributor Author

smk1993 commented May 13, 2024 •
edited

@hariombalhara , should it be done this way ?

@dosubot dosubot bot added the app-store area: app store, apps, calendar integrations, google calendar, outlook, lark, apple calendar label May 13, 2024
@graphite-app Graphite App
Copy link

graphite-app bot commented May 13, 2024

Graphite Automations

"Add community label" took an action on this PR • (05/13/24)

1 label was added to this PR based on Keith Williams's automation.

"Add consumer team as reviewer" took an action on this PR • (05/13/24)

1 reviewer was added to this PR based on Keith Williams's automation.

@github-actions GitHub Actions
Copy link
Contributor

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

New Pages Added

The following pages were added to the bundle from the code in this PR:

Page Size (compressed) First Load % of Budget (350 KB)
/settings/organizations/platform/oauth-clients 262.92 KB 491.33 KB 140.38%
/settings/organizations/platform/oauth-clients/create 263.02 KB 491.43 KB 140.41%

Seventy-nine Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/[user]/[type] 411.21 KB 639.62 KB 182.75% (🟢 -0.25%)
/[user]/[type]/embed 411.21 KB 639.63 KB 182.75% (🟢 -0.25%)
/apps 276.58 KB 505 KB 144.28% (🟢 -0.66%)
/apps/[slug] 294.29 KB 522.71 KB 149.35% (🟢 -0.61%)
/apps/[slug]/[...pages] 585.37 KB 813.79 KB 232.51% (🟢 -0.58%)
/apps/categories 254.55 KB 482.96 KB 137.99% (🟢 -0.60%)
/apps/categories/[category] 258.87 KB 487.28 KB 139.22% (🟢 -0.60%)
/apps/installed/[category] 277.99 KB 506.4 KB 144.69% (🟢 -0.63%)
/auth/setup 148.63 KB 377.04 KB 107.73% (🟢 -0.15%)
/availability 462.52 KB 690.93 KB 197.41% (🟡 +9.97%)
/availability/[schedule] 408.91 KB 637.32 KB 182.09% (🟢 -0.69%)
/bookings/[status] 322.3 KB 550.72 KB 157.35% (🟢 -0.62%)
/d/[link]/[slug] 411.02 KB 639.43 KB 182.70% (🟢 -0.25%)
/enterprise 254.61 KB 483.02 KB 138.01% (🟢 -0.60%)
/event-types 554.57 KB 782.98 KB 223.71% (🟢 -0.50%)
/event-types/[type] 433.6 KB 662.02 KB 189.15% (🟢 -0.77%)
/getting-started/[[...step]] 404.04 KB 632.45 KB 180.70% (🟢 -0.14%)
/insights 473.02 KB 701.44 KB 200.41% (🟢 -0.74%)
/more 254.11 KB 482.53 KB 137.86% (🟢 -0.60%)
/org/[orgSlug]/[user]/[type] 411.41 KB 639.82 KB 182.81% (🟢 -0.25%)
/org/[orgSlug]/[user]/[type]/embed 411.43 KB 639.84 KB 182.81% (🟢 -0.25%)
/org/[orgSlug]/instant-meeting/team/[slug]/[type] 411.03 KB 639.45 KB 182.70% (🟢 -0.25%)
/org/[orgSlug]/team/[slug]/[type] 411.23 KB 639.64 KB 182.76% (🟢 -0.25%)
/settings/admin 260.4 KB 488.81 KB 139.66% (🟢 -0.55%)
/settings/admin/apps 273.21 KB 501.62 KB 143.32% (🟢 -0.64%)
/settings/admin/apps/[category] 273.17 KB 501.58 KB 143.31% (🟢 -0.65%)
/settings/admin/flags 264.2 KB 492.61 KB 140.75% (🟢 -0.64%)
/settings/admin/impersonation 260.7 KB 489.11 KB 139.75% (🟢 -0.60%)
/settings/admin/oAuth 271.83 KB 500.24 KB 142.93% (🟢 -0.76%)
/settings/admin/oAuth/oAuthView 94.12 KB 322.53 KB 92.15% (🟢 -0.44%)
/settings/admin/orgMigrations/_OrgMigrationLayout 248.99 KB 477.4 KB 136.40% (🟢 -0.64%)
/settings/admin/orgMigrations/moveTeamToOrg 297.91 KB 526.33 KB 150.38% (🟢 -0.71%)
/settings/admin/orgMigrations/moveUserToOrg 317.17 KB 545.58 KB 155.88% (🟢 -0.74%)
/settings/admin/orgMigrations/removeTeamFromOrg 297.69 KB 526.11 KB 150.32% (🟢 -0.70%)
/settings/admin/orgMigrations/removeUserFromOrg 297.71 KB 526.12 KB 150.32% (🟢 -0.69%)
/settings/admin/organizations 262.28 KB 490.69 KB 140.20% (🟢 -0.46%)
/settings/admin/organizations/[id]/edit 260.94 KB 489.36 KB 139.82% (🟢 -0.50%)
/settings/admin/users 263.04 KB 491.46 KB 140.42% (🟢 -0.44%)
/settings/admin/users/[id]/edit 391.07 KB 619.48 KB 177.00% (🟢 -0.62%)
/settings/admin/users/add 390.81 KB 619.22 KB 176.92% (🟢 -0.61%)
/settings/billing 260.6 KB 489.01 KB 139.72% (🟢 -0.52%)
/settings/developer/api-keys 264.97 KB 493.39 KB 140.97% (🟢 -0.43%)
/settings/developer/webhooks 265.1 KB 493.52 KB 141.01% (🟢 -0.42%)
/settings/developer/webhooks/[id] 266.05 KB 494.47 KB 141.28% (🟢 -0.43%)
/settings/developer/webhooks/new 266.08 KB 494.5 KB 141.28% (🟢 -0.42%)
/settings/my-account/appearance 313.11 KB 541.53 KB 154.72% (🟢 -0.61%)
/settings/my-account/calendars 271.57 KB 499.99 KB 142.85% (🟢 -0.40%)
/settings/my-account/conferencing 272.46 KB 500.87 KB 143.11% (🟢 -0.52%)
/settings/my-account/out-of-office 265.58 KB 494 KB 141.14% (🟢 -0.43%)
/settings/my-account/profile 403.84 KB 632.25 KB 180.64% (🟢 -0.53%)
/settings/organizations/[id]/about 155.35 KB 383.77 KB 109.65% (🟢 -0.64%)
/settings/organizations/[id]/add-teams 155.34 KB 383.76 KB 109.65% (🟢 -0.64%)
/settings/organizations/appearance 284.23 KB 512.64 KB 146.47% (🟢 -0.61%)
/settings/organizations/billing 260.63 KB 489.05 KB 139.73% (🟢 -0.53%)
/settings/organizations/dsync 329.99 KB 558.41 KB 159.54% (🟡 +10.12%)
/settings/organizations/general 347.88 KB 576.29 KB 164.65% (🟢 -0.65%)
/settings/organizations/members 428.63 KB 657.04 KB 187.73% (🟡 +8.19%)
/settings/organizations/new 155.36 KB 383.77 KB 109.65% (🟢 -0.64%)
/settings/organizations/privacy 265.78 KB 494.2 KB 141.20% (🟢 -0.66%)
/settings/organizations/profile 396.38 KB 624.79 KB 178.51% (🟢 -0.60%)
/settings/organizations/sso 271.13 KB 499.54 KB 142.73% (🟢 -0.58%)
/settings/organizations/teams/other 261.46 KB 489.87 KB 139.96% (🟢 -0.46%)
/settings/organizations/teams/other/[id]/appearance 273.11 KB 501.52 KB 143.29% (🟢 -0.60%)
/settings/organizations/teams/other/[id]/members 267.93 KB 496.35 KB 141.81% (🟢 -0.63%)
/settings/organizations/teams/other/[id]/profile 467.2 KB 695.61 KB 198.75% (🟢 -0.60%)
/settings/security/impersonation 265.79 KB 494.2 KB 141.20% (🟢 -0.44%)
/settings/security/password 302.72 KB 531.14 KB 151.75% (🟢 -0.61%)
/settings/security/sso 270.38 KB 498.8 KB 142.51% (🟢 -0.60%)
/settings/security/two-factor-auth 269.25 KB 497.67 KB 142.19% (🟢 -0.43%)
/settings/teams 260.14 KB 488.55 KB 139.59% (🟢 -0.53%)
/settings/teams/[id]/appearance 273.09 KB 501.51 KB 143.29% (🟢 -0.60%)
/settings/teams/[id]/billing 260.64 KB 489.05 KB 139.73% (🟢 -0.53%)
/settings/teams/[id]/profile 468.03 KB 696.44 KB 198.98% (🟢 -0.60%)
/team/[slug]/[type] 411.2 KB 639.61 KB 182.75% (🟢 -0.25%)
/team/[slug]/[type]/embed 411.23 KB 639.64 KB 182.75% (🟢 -0.24%)
/teams 254.34 KB 482.75 KB 137.93% (🟢 -0.60%)
/upgrade 254.46 KB 482.88 KB 137.96% (🟢 -0.60%)
/workflows 285.68 KB 514.1 KB 146.88% (🟢 -0.63%)
/workflows/[workflow] 408.04 KB 636.46 KB 181.85% (🟢 -0.66%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

@keithwillcode keithwillcode added this to the v4.2 milestone May 15, 2024
@github-actions GitHub Actions
Copy link
Contributor

This PR is being marked as stale due to inactivity.

@github-actions github-actions bot added the Stale label May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
app-store area: app store, apps, calendar integrations, google calendar, outlook, lark, apple calendar community Created by Linear-GitHub Sync ✨ feature New feature or request ✅ good first issue Good for newcomers Low priority Created by Linear-GitHub Sync ⚡ Quick Wins A collection of quick wins/quick fixes that are less than 30 minutes of work Stale
Projects
None yet
Milestone
v4.2
Development

Successfully merging this pull request may close these issues.

[CAL-3584] Add zod schemas for app metadata living in config.json
2 participants
@smk1993 @keithwillcode