Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CAL-3584] Add zod schemas for app metadata living in config.json #14808

Open
joeauyeung opened this issue Apr 30, 2024 · 4 comments · May be fixed by #14997
Open

[CAL-3584] Add zod schemas for app metadata living in config.json #14808

joeauyeung opened this issue Apr 30, 2024 · 4 comments · May be fixed by #14997
Labels
✨ feature New feature or request ✅ good first issue Good for newcomers Low priority Created by Linear-GitHub Sync ⚡ Quick Wins A collection of quick wins/quick fixes that are less than 30 minutes of work
Milestone
v4.2

Comments

@joeauyeung
Copy link
Contributor

joeauyeung commented Apr 30, 2024 •
edited

When an app's metadata lives in a config.json file we lose typing. Instead we should have a zod schema similar to our AppMeta type that can parse the json file and give us proper typing.

From SyncLinear.com | CAL-3584
@joeauyeung joeauyeung added Low priority Created by Linear-GitHub Sync ⚡ Quick Wins A collection of quick wins/quick fixes that are less than 30 minutes of work ✅ good first issue Good for newcomers labels Apr 30, 2024
@dosubot dosubot bot added the ✨ feature New feature or request label Apr 30, 2024
@hemantwasthere
Copy link

Hey @joeauyeung, I would like to work on this issue

@sotayamashita sotayamashita mentioned this issue May 1, 2024
Closed
11 tasks
@sotayamashita
Copy link

@hemantwasthere
I created the PR experimentally and accidentally linked the issue. you can ignore my PR.
I am sorry for the confusion

@Deep512
Copy link

Deep512 commented May 3, 2024

@joeauyeung @sotayamashita
I am unable to grasp the complete requirement of this issue and also can't open these links here

From SyncLinear.com | CAL-3584

So can you give a brief description of what exactly is required here?

@joeauyeung
Copy link
Contributor Author

@joeauyeung @sotayamashita I am unable to grasp the complete requirement of this issue and also can't open these links here

From SyncLinear.com | CAL-3584

So can you give a brief description of what exactly is required here?

Sorry about that. I just updated the description.

This was referenced May 9, 2024
Closed
Open
@dosubot dosubot bot added this to the v4.2 milestone May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
✨ feature New feature or request ✅ good first issue Good for newcomers Low priority Created by Linear-GitHub Sync ⚡ Quick Wins A collection of quick wins/quick fixes that are less than 30 minutes of work
Projects
None yet
Milestone
v4.2
4 participants
@sotayamashita @Deep512 @joeauyeung @hemantwasthere