[bitsail] support doris source connector #473
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garyli1019
reviewed
May 15, 2023
| * <p> | ||
| * select id, bigint_type, string_type, double_type from doris_table where id = 1 | ||
| */ | ||
| public void addDorisInfo(BitSailConfiguration jobConf) { |
There was a problem hiding this comment.
@DongLiang-0 Thanks for your contribution! Are you using your local environment for testing? I am testing doris myself recently, and found we can actually use test container to simplify the testing experience. It took me a while to start a doris cluster in my local machine. If you are interested, we can actually add the doris test container with this PR. Maybe contribute to the testcontainer project as well. DockerComposeContainer
There was a problem hiding this comment.
Thanks for your suggestion, I will try
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prepare a Pull Request
Title: [BitSail-XYZ][XxxType] Title of the pull request
Fixes: #XYZ
Motivation
Describe what this PR does and what problems you're trying to solve.
Modifications
Describe the modifications you've done.
Verifying this change
Please pick either of the following options.
This change is a trivial rework/code cleanup without any test coverage.
This change is already covered by existing tests, such as:
(please describe tests, example:)
This change added tests and can be verified as follows:
(example:)
Documentation