feat(sql-review): new rule for checking no position in add column clause #11953
+184
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whhe
requested review from
LiuJi-Jim,
boojack,
a team,
rebelice,
h3n4l,
d-bytebase and
ecmadao
as code owners
|
We are missing i18n for other locales. @rebelice can help with the review, and thanks for the contribution! |
i18n test is broken, fixed here #11973 |
I rebased this branch and the frontend-tests failed. Is it due to missing i18n text? |
|
Missing i18n text added. I used chatgpt for translation and I'm not sure if the text is correct. |
rebelice
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Statements like
alter table t add column a ... after bare offline ddl on some 4.x versions of OceanBase (MySQL mode) and online ddl for others, so there should be a warning for it to help the DBA filter it out.For localization, I just add the rule to zh-CN.json and en-US.json, as other languages are too difficult for me.