Introduce end-2-end codegen tests & prepare ground for issue #39 #42
Conversation
|
|
||
| // Split the String per lines to make debugging/diffing | ||
| // viable (it also improves diff performance at test time) | ||
| let v : Vec<_> = formatted.lines().map(ToString::to_string).collect(); |
There was a problem hiding this comment.
Does this need to be assigned to a variable?
There was a problem hiding this comment.
collect needs to know the required type, so either this variable or using the turbofish operator. I'm partial to variables because it's usually more explicit/readable, expresses the intent better. (This is needed to let the macro return a Vec)
There was a problem hiding this comment.
Sure I just mean as opposed to turbofish, which I find easier for reading an expression from start to finish without having to go back some number of lines to remember what's being collected. However I don't feel too strongly about it.
There was a problem hiding this comment.
However I don't feel too strongly about it.
Same 🙂. My main grippe with turbofish is that sometimes functions take more than one generic, and there's more to annotate than just one type even though we're interested in only one of them: that's not the case for collect so I'm fine with both.
Draft, early review welcome @cpcloud @lovesegfault
I'm not sure
srcis the best place to put the expected source code, especially because it is Rust and it may be confused with code that is actually ran (a different extension might help, but breaks syntax highlighting from IDEs, which is appreciated), andtestsis usually reserved for integration tests (where one can call into the crate as a 3rd party).Ideas welcome!