Delete: projects and labels with requirements #43
Conversation
Allow and ability to delete projects and labels. This will show a warning message before deleting. This will also delete tasks by cascade operation.
| void checkIfLabelExist(Label label) async { | ||
| _labelDB.isLabelExits(label).then((isExist) { | ||
| _labelExistController.sink.add(isExist); | ||
| void createOrExists(Label label) async { |
There was a problem hiding this comment.
Can you please write unit tests for this?
There was a problem hiding this comment.
Test case : "Add label if not exist in the label db test" and "Don't Add label if exist in the label db test" are covering this functionality.
| }); | ||
| } | ||
|
|
||
| void updateColorSelection(ColorPalette colorPalette) { | ||
| _colorController.sink.add(colorPalette); | ||
| } | ||
|
|
||
| void deleteLabel(int labelID) async { |
There was a problem hiding this comment.
Can you please write unit tests for this?
There was a problem hiding this comment.
test case Delete label in label list test covers this.
There was a problem hiding this comment.
the test is located in WhatTodo\test\label_bloc_test.dart
| onTap: () { | ||
| homeBloc.applyFilter("@ ${label.name}", Filter.byLabel(label.name)); | ||
| context.safePop(); | ||
| return Dismissible( |
There was a problem hiding this comment.
Need test for this widget
There was a problem hiding this comment.
ok, test done Swipe left/right to delete label
There was a problem hiding this comment.
the test is located in WhatTodo\test\label_dismissible_widget_test.dart
| @@ -37,13 +43,28 @@ class ProjectBloc implements BlocBase { | |||
| }); | |||
| } | |||
|
|
|||
| void createOrExists(Project project) async { | |||
| _projectDB.projectExists(project).then((exist) { | |||
There was a problem hiding this comment.
What would have happened if the project already exists? Also, can you please write test for this.
There was a problem hiding this comment.
Test case Don't Add project if exist in the project db test is covering this.
| onTap: () { | ||
| homeBloc.applyFilter(project.name, Filter.byProject(project.id!)); | ||
| context.safePop(); | ||
| return Dismissible( |
There was a problem hiding this comment.
Test for dismissing widget to delete project
There was a problem hiding this comment.
Test case Swipe left to delete project is covering this.
Allow and ability to delete projects and labels. This will show a warning message before deleting. This will also delete tasks by cascade operation.