Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bootstrap migrate non-modifications #1

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

AzzieDev
Copy link

@AzzieDev AzzieDev commented Nov 28, 2023

This was a rushed hack job done by hand by Diff-checking the CSS files of Bootstrap and the project, so I may have missed a few lines, but everything appears to be in order for the most part. This was not an easy task as I did not automate the process.

Bootstrap stylesheets shouldn't be edited directly, but rather be referenced to be cached on the user's browsers, and then necessary modifications be performed in their own stylesheets per page or site-wide.

Several issues this Pull Request does not fix:

  • The app.css stylesheet is NOT dark-mode friendly and renders most content as a forced light theme, as certain colors are defined without regard to the theme, after about line 1439 which was Line 11999 of original. For example, this rule assigns black text and a Ghost White background to the body.
  • If the user opens the Notification bar when they have scrolled down in desktop view, the bar can not be closed as the button is only visible at the top. The element needs to be stickied or have some other style modification to prevent this issue.
  • The navigation, headers, footers, and such are duplicated for each page that uses it and would need to be edited individually for each page to have an identical set. There are many solutions to this problem, such as using a wrapper page and dynamically loading the page contents using vanilla JavaScript, using dedicated libraries within web frameworks like Angular, Vue, or React, or using PHP for handling the headers and footers, which appear to be goals within the project.
  • The app.js script appears to be a series of libraries assembled in a single file, that are likely better off cached on user's browsers referenced from CDNs, than all in a single heavy file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant