Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test selecting time-zone during signup #435

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

pascallaliberte
Copy link
Member

The process of selecting a time-zone during sign up is cumbersome because too many clicks are needed to use type-ahead search for super_select field that allow a single selection.

Also, the existing select2_select helper only works with super_select fields that allow multiple selections.

This PR:

  • Makes the select2_select helper work with super_select fields that allow only a single selection. It simulates typing into the un-opened field and continues to type with the super_select dropdown opened and the input field in focus.
  • Adds a step to authentication_test to select the Time Zone during sign up.

Co-dependent PRs (required for the test to pass):

@pascallaliberte
Copy link
Member Author

With the associated PRs, we get this smooth, smooth time-zone-picking flow:

CleanShot 2022-09-21 at 14 26 20

@jagthedrummer
Copy link
Contributor

jagthedrummer commented Aug 1, 2023

@pascallaliberte This looks good to me, and it looks like the dependent PRs were replaced by one in core that has already been merged (bullet-train-co/bullet_train-core#63). So is it accurate that this one should be ready to merge now? If so we should re-trigger CircleCI, which I don't have permission to do, so we can make sure that tests are passing. (It looks like they failed previously, but it's been so long that Circle doesn't seem to have those test runs available to inspect anymore.)

@jagthedrummer
Copy link
Contributor

@pascallaliberte I saw that there was a linter error in Circle, so I fixed that, which got a new Circle run to kick off. But now there seems to be a legitimate failure related to these new tests. Can you take a look?

@jagthedrummer
Copy link
Contributor

@pascallaliberte Is this still something you'd like to get merged?

@jagthedrummer jagthedrummer marked this pull request as draft August 22, 2023 19:05
@pascallaliberte
Copy link
Member Author

@jagthedrummer yes, I'll scrub and polish it next week

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants