react-base: Improve BuildView 'Rebuild' topbar action #7597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p12tic
approved these changes
May 12, 2024
Provide better feedback to user with the following changes: - Caption is now one of 'Rebuilt' (finished rebuild), 'Rebuilding' (rebuild in progress), 'Rebuild pending' (rebuild requested but not started). - Button now redirect to the Buildrequest for the rebuild, which will redirect to the Build if it started. - If multiple rebuild were issued, redirection is done to the newest one (can be changed to the one closest to the Build viewed, see NOTE in code). - When 'Rebuild' button is clicked but new Buildrequest wasn't found yet, caption is 'Rebuilding' as before, but button is a noop.
p12tic
force-pushed
the
react-base/improve-build-rebuild-ui
branch
from
802c037
to
c8486bb
Compare
|
Rebased. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide better feedback to user with the following changes:
Closes #7450
Contributor Checklist:
newsfragmentsdirectory (and read theREADME.txtin that directory)