buildrequestdistributor: Sort pending builders only once #7512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vibbo
force-pushed
the
private/vibbo/improvement/build_request_distributor
branch
from
61dbdfb
to
01cfbab
Compare
Sorting pending builder each time the list is updated is unnecessary overhead. This can be done once the list is passed on to BuildRequestDistributor._activityLoop.
vibbo
force-pushed
the
private/vibbo/improvement/build_request_distributor
branch
from
01cfbab
to
4a2050d
Compare
|
I'm not confident with merging this change. I would need to review the algorithm used. |
Is there anything I can do to help now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorting pending builder each time the list is updated is unnecessary overhead. This can be done once the list is passed on to BuildRequestDistributor._activityLoop.
newsfragmentsdirectory (and read theREADME.txtin that directory)I was debugging some issues with BuildRequestDistributor and I find this change is an improvement of the existing implementation.
The question is, am I missing something? Is there actually any reason for the current implementation where pending builders are sorted each time the list is updated?
I will create newsfragment if the change is viable.