reporters/github: Add regex for report notifications only for allowed… #6601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p12tic
reviewed
Aug 18, 2022
p12tic
reviewed
Aug 18, 2022
p12tic
reviewed
Aug 18, 2022
p12tic
reviewed
Aug 18, 2022
p12tic
requested changes
Aug 18, 2022
There was a problem hiding this comment.
Thanks for the PR. Basic idea makes sense, I've added some comments for improvements.
Also, a unit test is needed to ensure that the regex filtering works. You can see how TestGitHubCommentPush reuses TestGitHubStatusPush to create custom reporter class (in this case we just need custom reporter argument).
aliceinwire
force-pushed
the
update_github
branch
3 times, most recently
from
4a55c0e
to
59f4c0b
Compare
|
Looks good. We now need tests, documentation update and a release note. |
aliceinwire
force-pushed
the
update_github
branch
4 times, most recently
from
6fcca76
to
b245a6f
Compare
… repository reporters/gitlab and reporters/github are conflicting if both are using sourcestamps repository settings. this is making gitlab MR try to report to github. for filtering such behaviour I have enabled a github baseREGEX option on the github reporter that is allowing only notifications towards allowed sourcestamps repository. Signed-off-by: Alice Ferrazzi <[email protected]>
aliceinwire
force-pushed
the
update_github
branch
from
b245a6f
to
9ce82e1
Compare
Signed-off-by: Alice Ferrazzi <[email protected]>
aliceinwire
force-pushed
the
update_github
branch
3 times, most recently
from
eaeefa8
to
fc33f52
Compare
|
@p12tic added documentation |
aliceinwire
force-pushed
the
update_github
branch
2 times, most recently
from
2cbf0c3
to
43fe504
Compare
Adding test for testing the option base_re Signed-off-by: Alice Ferrazzi <[email protected]>
aliceinwire
force-pushed
the
update_github
branch
from
43fe504
to
d360839
Compare
|
sorry I couldn't work out how to add the tests about this PR, could you help out? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reporters/gitlab and reporters/github are conflicting if both are using
sourcestamps repository settings. this is making gitlab MR try to report
to github. for filtering such behaviour I have enabled a github
baseREGEX option on the github reporter that is allowing only
notifications towards allowed sourcestamps repository.
Signed-off-by: Alice Ferrazzi [email protected]