Updating steps.Git to allow incremental fetch. #6483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR fixes #6482 |
shareefj
force-pushed
the
bugfix/allow_incremental_clone
branch
from
d22219d
to
2e4e352
Compare
|
@shareefj Thanks for the PR. The difference between full and incremental checkouts is that in the former case previous repository is thrown away and cloned cleanly, whereas in the incremental checkout case the existing repository is reused. I think in this case it makes sense to introduce an additional mode, e.g. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix updates
Git#_fetchto checkself.mode == 'incremental'before performing the checkout. I've updated all the tests but wanted some feedback given this seems to be such fundamental behaviour. It may be that I'm misunderstanding how this should work as I can't have been the first person to try an 'incremental' update.Contributor Checklist:
newsfragmentsdirectory (and read theREADME.txtin that directory)