Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reconsider nextWorker for each build request #6277

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Reconsider nextWorker for each build request #6277

wants to merge 2 commits into from

Commits on Oct 7, 2021

  1. Reconsider nextWorker for each build request 

    When the ability for nextWorker to make decisions based on the build
request was added, the processing of workers was not updated to ensure
it would consider each request separately. This caused the immediate
issue that popNextBuild would only consider the first build request if
nextWorker was unable to place it. Additionally, once a worker had been
asked to consider a given build request, this decision persisted to
future unrelated build requests if the build was prevented from starting
by Builder.canStartBuild.

The fix for both of these issues is always considering every available
worker for each build request as they are chosen by nextBuild.
    @arbor-bdoyle
    arbor-bdoyle committed Oct 7, 2021
    Configuration menu
    Copy the full SHA
    7db5e12 View commit details
    Browse the repository at this point in the history

  2. Update BasicBuildChooser documentation

    @arbor-bdoyle
    arbor-bdoyle committed Oct 7, 2021
    Configuration menu
    Copy the full SHA
    322a936 View commit details
    Browse the repository at this point in the history