Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make GerritStatusPush also work with GitPoller source #5956

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

muks
Copy link
Contributor

@muks muks commented Mar 28, 2021

It would previously work with GerritChangeSource and
GerritEventLogPoller only. But using events from these Gerrit specific
changesources can be problematic for some users, and so we support
GitPoller as well.

Reviews are sent back to the Gerrit server for builds with refspecs
matching: refs/changes/n/n/n

Contributor Checklist:

  • I have updated the unit tests
  • I have created a file in the master/buildbot/newsfragments directory (and read the README.txt in that directory)
  • I have updated the appropriate documentation

@codecov
Copy link

codecov bot commented Mar 28, 2021

Codecov Report

Merging #5956 (7eb345f) into master (9e07314) will decrease coverage by 0.01%.
The diff coverage is 11.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5956      +/-   ##
==========================================
- Coverage   91.81%   91.79%   -0.02%     
==========================================
  Files         340      340              
  Lines       36343    36352       +9     
==========================================
+ Hits        33367    33368       +1     
- Misses       2976     2984       +8     
Impacted Files Coverage Δ
master/buildbot/reporters/gerrit.py 84.77% <11.11%> (-2.37%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e07314...7eb345f. Read the comment docs.

@muks muks force-pushed the make-gerritstatuspush-work-with-gitpoller branch from 98db812 to 3292025 Compare March 28, 2021 17:03
It would previously work with GerritChangeSource and
GerritEventLogPoller only. But using events from these Gerrit specific
changesources can be problematic for some users, and so we support
GitPoller as well.

Reviews are sent back to the Gerrit server for builds with refspecs
matching: refs/changes/n/n/n
@muks muks force-pushed the make-gerritstatuspush-work-with-gitpoller branch from 3292025 to 7eb345f Compare March 28, 2021 17:05
Copy link
Member

@p12tic p12tic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in principle. This will need a unit test and a news fragment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants