Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable the nested virtualization warning by default. #421

Merged
merged 1 commit into from May 3, 2024

Conversation

muvaf
Copy link
Contributor

@muvaf muvaf commented Apr 27, 2024

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Purpose of changes

When run in nested virtualization, a warning dialog shows up saying that the performance may not be good but that's not really helpful and in fully-automated scenarios, it creates unnecessary distraction.

Fixes #281

@budtmo
Copy link
Owner

budtmo commented May 3, 2024

Thank you @muvaf for the PR

@budtmo budtmo merged commit c5cce78 into budtmo:master May 3, 2024
1 check passed
@muvaf muvaf deleted the patch-1 branch May 6, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Emulator is running using nested virtualization. This is not recommended. It may not work at all...
2 participants