-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preparations - v3.0.0 #230
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Jun 12, 2024
Closed
btschwertfeger
added
Futures
Topic related to Futures trading
Spot
Topic related to Spot trading
Breaking
Breaking changes
labels
Jun 15, 2024
This was
linked to
issues
Jun 15, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #230 +/- ##
===========================================
+ Coverage 0.00% 87.10% +87.10%
===========================================
Files 28 25 -3
Lines 2226 2055 -171
===========================================
+ Hits 0 1790 +1790
+ Misses 2226 265 -1961
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Closed
btschwertfeger
force-pushed
the
228-async-rest-api
branch
from
June 22, 2024 06:02
25fcc3e
to
d5b2b48
Compare
btschwertfeger
force-pushed
the
228-async-rest-api
branch
from
June 22, 2024 06:15
d5b2b48
to
e39e385
Compare
btschwertfeger
force-pushed
the
228-async-rest-api
branch
from
June 22, 2024 06:45
e39e385
to
5f34019
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Breaking
Breaking changes
enhancement
New feature or request
Futures
Topic related to Futures trading
Spot
Topic related to Spot trading
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
request
function, rather than individual methods.start
/stop
-methods (Resolve "Websocket Logic Refactor - start/stop mechanism" #233)Considerations:
#228 introduces the idea of async requests. It was decided to use aiohttp instead of other packages, like xhttp, since seems to provides a larger community and stable releases - in contrast to xhttp.
Notes/Todo's: