Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preparations - v3.0.0 #230

Merged
merged 15 commits into from
Jun 23, 2024
Merged

Preparations - v3.0.0 #230

merged 15 commits into from
Jun 23, 2024

Conversation

btschwertfeger
Copy link
Owner

@btschwertfeger btschwertfeger commented Jun 10, 2024

Changes:

Considerations:

#228 introduces the idea of async requests. It was decided to use aiohttp instead of other packages, like xhttp, since seems to provides a larger community and stable releases - in contrast to xhttp.

Notes/Todo's:

@btschwertfeger btschwertfeger added the enhancement New feature or request label Jun 10, 2024
@btschwertfeger btschwertfeger added this to the Upcoming Release milestone Jun 10, 2024
@btschwertfeger btschwertfeger self-assigned this Jun 10, 2024
This was linked to issues Jun 12, 2024
@btschwertfeger btschwertfeger changed the title Resolve "Add async REST API" Preparations - v3.0.0 Jun 12, 2024
Copy link

codecov bot commented Jun 15, 2024

Codecov Report

Attention: Patch coverage is 87.81609% with 53 lines in your changes missing coverage. Please review.

Project coverage is 87.10%. Comparing base (118cd0a) to head (5f34019).
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #230       +/-   ##
===========================================
+ Coverage    0.00%   87.10%   +87.10%     
===========================================
  Files          28       25        -3     
  Lines        2226     2055      -171     
===========================================
+ Hits            0     1790     +1790     
+ Misses       2226      265     -1961     
Flag Coverage Δ
unittests 87.10% <87.81%> (+87.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
kraken/cli.py 87.69% <100.00%> (+87.69%) ⬆️
kraken/futures/__init__.py 100.00% <100.00%> (+100.00%) ⬆️
kraken/futures/trade.py 94.56% <100.00%> (+94.56%) ⬆️
kraken/nft/market.py 93.93% <100.00%> (+93.93%) ⬆️
kraken/spot/__init__.py 100.00% <100.00%> (+100.00%) ⬆️
kraken/spot/market.py 100.00% <100.00%> (+100.00%) ⬆️
kraken/spot/orderbook.py 94.93% <100.00%> (ø)
kraken/spot/user.py 99.11% <100.00%> (+99.11%) ⬆️
kraken/spot/ws_client.py 91.80% <100.00%> (ø)
kraken/futures/market.py 91.57% <90.00%> (+91.57%) ⬆️
... and 11 more

... and 2 files with indirect coverage changes

@btschwertfeger btschwertfeger linked an issue Jun 20, 2024 that may be closed by this pull request
@btschwertfeger btschwertfeger marked this pull request as ready for review June 23, 2024 10:23
@btschwertfeger btschwertfeger merged commit d3efe88 into master Jun 23, 2024
41 checks passed
@btschwertfeger btschwertfeger deleted the 228-async-rest-api branch June 23, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment