Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add async REST API #228

Closed
Trevypants opened this issue Jun 9, 2024 · 1 comment · Fixed by #230
Closed

Add async REST API #228

Trevypants opened this issue Jun 9, 2024 · 1 comment · Fixed by #230
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@Trevypants
Copy link

Describe the solution you'd like

First of all, thank you for making such a clean Kraken client library. It is really refreshing to see. However, when investigating your code, I noticed that you are using the standard requests library which only supports synchronous API calls. Since we are working with API calls that I/O bound, asynchronous API calls would really help speed up applications that need to make many API calls at once.

There are many asynchronous libraries out there that could replace requests. For example httpx offers both synchronous and asynchronous support. Or alternatively aiohttp which is found to be faster than httpx but only supports async.

Describe alternatives you've considered

Here is another Kraken Python client library that supports async: kraky.

@btschwertfeger
Copy link
Owner

Hey @Trevypants, great idea! I'll have a look into it.

@btschwertfeger btschwertfeger self-assigned this Jun 9, 2024
@btschwertfeger btschwertfeger added the enhancement New feature or request label Jun 9, 2024
@btschwertfeger btschwertfeger changed the title Async REST API Add async REST API Jun 10, 2024
@btschwertfeger btschwertfeger linked a pull request Jun 12, 2024 that will close this issue
21 tasks
@btschwertfeger btschwertfeger added this to the v3.0.0 milestone Jun 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants