New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Design system and icon updates for 2.0 #5938
Conversation
iconography reference issue: #5485 |
Documenting as I work through everything. Might have more comments, will add them as I go. Few suggestions and nits:
|
ba87501
to
c2276b8
Compare
9a3e857
to
c73add9
Compare
This one is ready for now, let's try to integrate it soon. Can you give it a review, @dstrukt? |
Code ACK, didn't visually checked though |
Have a few last icons for you that won't dramatically change up the code, but yes - will get this reviewed/merged asap! We're not planning to deprecate the Font Awesome code in this PR are we? |
Shouldn't this be the Otherwise, sent the remaining icons via DM. Will get my review in here shortly! |
The dots are for the "waiting" states, like waiting for the connection or user inout. It was a "?" before, but I think the dots work better here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK! Changes LGTM, assuming there will be no issues with the latest icon additions, and can always apply a patch if there's any strange errors that arise.
The only regression I've noticed is on the app side, with the invoices tab being changed to the other document looking icon, instead of the below (which is what it should be):
Ok, now everything is replaced and Font Awesome is removed 🎉 |
WIP, will update this in an ongoing manner as we progress with 2.0 and the app.
Closes #5485.