Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added "project-name" param so containers have better names #551

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

woutersamaey
Copy link
Contributor

@woutersamaey woutersamaey commented Nov 3, 2021

Containers won't have the generated_ prefix anymore, but btcpayserver_ instead. The generated_ prefix comes from the dir name Generated where the docker-compose.yml is at and this is default behaviour.

WARNING: This can be tricky and maybe even dangerous if best practices were not followed. Let's discuss.

This change helps to find containers that are part of the BTCPay Server on a server that's running other apps as well.

All I did was add -p btcpayserver to all docker-compose commands.

Containers won't have the "generated-" prefix anymore, but "btcpayserver-"
@Kukks
Copy link
Member

Kukks commented Jun 6, 2022

I think this would be a breaking change for some scripts.

@NicolasDorier
Copy link
Member

Yes, while I agree this should have been done from day 1, I am against changing it now as it will breaks quite a lot of things. (documentations and scripts)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants