Correct implementation of Laguerre's method #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryanwweber
reviewed
Jun 15, 2024
There was a problem hiding this comment.
Thank you for this! The square root is definitely something I missed. Thanks also for fixing the typo with the extra left parentheses. I actually think it's clearer that the ^2 applies to f'(\chi_i) and not just \chi if there are extra parentheses added. What do you think?
time-since-periapsis-and-keplers-equation/universal-variables.md
Outdated
Show resolved
Hide resolved
|
Agreed, this looks much clearer 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it stands the suggested implementation of Laguerre's method is incorrect. This is the expression from in the cited source (PC13).