Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: multi-version playwright endpoints #4059

Merged
merged 10 commits into from
May 17, 2024
Merged

feat: multi-version playwright endpoints #4059

merged 10 commits into from
May 17, 2024

Conversation

andyMrtnzP
Copy link
Collaborator

No description provided.

@andyMrtnzP andyMrtnzP marked this pull request as ready for review May 16, 2024 22:47
@zach-browserless zach-browserless requested review from AlexLoyola and removed request for AlexLoyola May 17, 2024 15:17
@joelgriffith
Copy link
Collaborator

ws://localhost:3000/playwright/chrome should be ws://localhost:3000/chrome/playwright. Trying to keep a format and naming convention of browser/action.

@andyMrtnzP
Copy link
Collaborator Author

@joelgriffith didn't catch that one, thanks! I realized the chrome test was failing because of that

joelgriffith
joelgriffith reviewed May 17, 2024
View reviewed changes
src/browserless.ts Outdated Show resolved Hide resolved
joelgriffith
joelgriffith reviewed May 17, 2024
View reviewed changes
src/browsers/index.ts Outdated Show resolved Hide resolved
joelgriffith
joelgriffith reviewed May 17, 2024
View reviewed changes
package.json Outdated Show resolved Hide resolved
@joelgriffith joelgriffith merged commit 730e613 into main May 17, 2024
8 checks passed
@joelgriffith joelgriffith deleted the feat/multi-playwright branch May 17, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joelgriffith joelgriffith joelgriffith approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@andyMrtnzP @joelgriffith