Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed: e.matches: null check #1196

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

ncaq
Copy link
Contributor

@ncaq ncaq commented Apr 8, 2020

My Firefox verbose error is

JavaScript error: moz-extension://c04083df-5b98-4196-b0f9-c185ea86eef1/content_scripts/modules.min.js, line 1: TypeError: e.matches is not a function

So, I add null check for e.matches.

My Firefox verbose error is

~~~
JavaScript error: moz-extension://c04083df-5b98-4196-b0f9-c185ea86eef1/content_scripts/modules.min.js, line 1: TypeError: e.matches is not a function
~~~

So, I add null check for `e.matches`.
@brookhong
Copy link
Owner

Thanks, but the error seems not to be caused by null element, as if e is null, it will raise error as below

TypeError: e is null

The cause seems to be that a non-element object was passed in, could you please provide a detail steps to reproduce your issue?

@ncaq
Copy link
Contributor Author

ncaq commented Apr 13, 2020

but the error seems not to be caused by null elemen

I'm sorry, it was a mistake.

could you please provide a detail steps to reproduce your issue?

This happens only when you open some pages.
This may not be a configuration problem, since it occurs even in the default settings of surfingkeys.
The location of the error log is .xsession-errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants