Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement vgoto #1559

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Implement vgoto #1559

wants to merge 3 commits into from

Conversation

bi4k8
Copy link
Collaborator

@bi4k8 bi4k8 commented May 30, 2023

Checklist

  • I have described the changes
  • I have linked to any relevant GitHub issues, if applicable
  • Documentation in doc/ has been updated
  • All new code is licensed under GPLv3

Description

This implements a vertical goto, to match the existing horizontal one. This has been requested by a number of users. Closes #450, and is based in part on the patch there by @easysid.

Tested against the following conkyrc:

conky.config = {
	out_to_wayland = true,
	use_xft= true,
	font= 'DejaVu Sans:style=medium:size=9'
}
conky.text = [[
foo bar${vgoto 0}${goto 0}text after vgoto

line 1
line 2
another
line 4
line 5
]]

This is still a draft because it seems to cause some issues calculating height--with the above conkyrc, on the first iteration, everything looks as expected, but at the beginning of the second iteration, the whole displayed output moves downward, and the bottom line gets cut off. I'll have to debug what's happening there. I have seen similar jumps previously, so it seems more likely that this is exacerbating an existing misbehavior than introducing a completely new one.

bi4k8 and others added 3 commits May 30, 2023 14:08
otherwise, one must explicitly goto a "magic" offset to match the position of the first text conky renders
@netlify
Copy link

netlify bot commented May 30, 2023

Deploy Preview for conkyweb ready!

Name Link
🔨 Latest commit d13320e
🔍 Latest deploy log https://app.netlify.com/sites/conkyweb/deploys/647605f3fb48e40008e00d11
😎 Deploy Preview https://deploy-preview-1559--conkyweb.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added documentation Issue or PR that suggests documentation improvements sources PR modifies project sources labels May 30, 2023
@Caellian
Copy link
Collaborator

Just letting you know that node kinds (variables) now use an enum class, so instead of VGOTO you'll have to write text_node_t::VGOTO. That seems to be the only merge issue introduced by my recent PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Issue or PR that suggests documentation improvements sources PR modifies project sources
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for absolute vertical alignment of text.
2 participants