Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(arm): RedisCacheEnableNonSSLPort - Valid SSL for Azure #6253

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

unu87
Copy link
Contributor

@unu87 unu87 commented May 6, 2024

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

The code department ensures that only SSL outputs are enabled for Azure Cache for Redis when enableNonSSLPort is set to False

Fixes # (issue)

For Azure Cache for Redis resources, the new policy requires that only SSL outputs be enabled, with the enableNonSSLPort property set to False. This adjustment is intended to bolster security and compatibility

Description

Include a description of what makes it a violation and any relevant external links.

Fix

How does someone fix the issue in code and/or in runtime?

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@ChanochShayner ChanochShayner changed the title feat(arm) RedisCacheEnableNonSSLPort - Valid SSL for Azure feat(arm): RedisCacheEnableNonSSLPort - Valid SSL for Azure May 6, 2024
Copy link
Contributor

@ChanochShayner ChanochShayner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
Please fix the mypy issues.

@unu87
Copy link
Contributor Author

unu87 commented May 21, 2024

we fix the issues and its faild again on this thing,
he didn't feal it...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants