Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default repo-id #137

Merged
merged 1 commit into from
Oct 26, 2023
Merged

Add default repo-id #137

merged 1 commit into from
Oct 26, 2023

Conversation

tsmithv11
Copy link
Contributor

In This PR

Add default repo-id

#136

Pictures/videos

  • I've reviewed my own code

@tsmithv11 tsmithv11 changed the title Update checkovRunner.ts Add default repo-id Oct 26, 2023
@mikeurbanski1 mikeurbanski1 merged commit 3aff59f into master Oct 26, 2023
1 of 2 checks passed
@mikeurbanski1 mikeurbanski1 deleted the add-default-repo-id branch October 26, 2023 21:06
@ultrajericho
Copy link

ultrajericho commented Oct 27, 2023

Maybe you should let us define the repo-id in the extension settings (or even allow it to be defined by folder/workspace) instead of forcing this "vscode" repo by default.

It should be a default value, but we should be able to override it.

Because in the way we defined security in our Prisma Cloud instance, it just doesnt work with this default repo.

@tsmithv11
Copy link
Contributor Author

Maybe you should let us define the repo-id in the extension settings (or even allow it to be defined by folder/workspace) instead of forcing this "vscode" repo by default.

It should be a default value, but we should be able to override it.

Because in the way we defined security in our Prisma Cloud instance, it just doesnt work with this default repo.

@ultrajericho thank you for the suggestion! The plugin does automatically add the repo-id if we can find it in the .git information. For defining your own repo-id, we currently don't support a way to define any setting per directory, so you would have to define one default repo for any directory we don't have the .git directory for. That is something we can look at doing in the future. For now, you can run a scan with the vscode/default repo-id and grant access to that repo in the developer role via Prisma Cloud.

@ultrajericho
Copy link

Ah, it's supposed to fetch .git? I didn't have that information. Thanks for your answer @tsmithv11 .

Still, it's strange because I have .git folders for those directories. Should I do something to give checkov access to this folder?
A priori, VSCode has access since I push/pull from the git interface in VSCode.

@tsmithv11
Copy link
Contributor Author

@ultrajericho it should be available to the plugin if the root directory of the git repository was the folder that was opened.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants