Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usually exceptions divide into checked and unchecked. It is more java concept, but also suitable for php world.
When
\LogicException
(unchecked) arises you don't usually want to catch and continue to work, better way is just show some error and fail fast. Because this exception means some bug in source code and only good way to deal with it - fix this bug.This is the reason why phpstorm skips
\LogicException
by default.My proposal is reorganisation money exceptions structure to make
MoneyMismatchException
andUnknownCurrencyException
unchecked by extending\LogicException
.Before:
What should I do? Write useless try-catch, or add
@throws
annotation (which will be a lie)After:
Phpstorm just skips this exception check.
Be aware, this changes is not really backward compatible!