LPS-125853 Switch to our @liferay/jquery-form fork
#98619
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of maintaining a patched copy of the upstream project:
https://github.com/jquery-form/form
in-line in this repo, we've made an actual fork of it:
https://github.com/liferay/liferay-frontend-projects/tree/master/third-party
and are pulling that in here via npm. This gives us a clear CHANGELOG.md
documenting where we've deviated from the upstream:
https://github.com/liferay/liferay-frontend-projects/blob/master/third-party/projects/jquery-form/CHANGELOG.md
Motivating use case here is closing an XSS whole by bringing in a fix
that is currently being ignored in the upstream repo:
jquery-form/form#586
|
To conserve resources, the PR Tester does not automatically run for forwarded pull requests. |
|
Merged. Thank you. |
|
Interesting.. but works. Thx @wincent |
liferay-continuous-integration
deleted the
ci-forward-wincent/LPS-125854-liferay-jquery-form-pr-772-sender-wincent-ts-1612953296041
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forwarded from: liferay-frontend#772 (Took 1
ci:forwardattempt in 0 ms)@wincent
@liferay-frontend
Original pull request comment:
Instead of maintaining a patched copy of the upstream project in-line in this repo, we've made an actual fork of it and are pulling that in here via npm. This gives us a clear CHANGELOG.md documenting where we've deviated from the upstream.
The motivating use case here is closing an XSS hole by bringing in a fix that is currently being ignored in the upstream repo.
To test, enabled jQuery in system settings and confirmed that
jquery/form.jsis coming down and that it indeed matches the patched version that we're shipping in our fork:✔️ ci:test:sf - 1 out of 1 jobs passed in 5 minutes
Click here for more details.
Base Branch:
Branch Name: master
Branch GIT ID: 4c4254711526d855334d6d7f40315aff5ffff6a0
Sender Branch:
Branch Name: wincent/LPS-125854-liferay-jquery-form
1 out of 1jobs PASSEDBranch GIT ID: cfe755432266eda26833ee3232ff383471ffc148
1 Successful Jobs:
For more details click here.
✔️ ci:test:stable - 9 out of 9 jobs passed
✔️ ci:test:relevant - 23 out of 23 jobs passed in 1 hour 39 minutes
Click here for more details.
Base Branch:
Branch Name: master
Branch GIT ID: 4318e2f9eb91ca3c0c74c377855994dac9dc8d80
Upstream Comparison:
Branch GIT ID: 7f8557eaa8e197a8cf8620cbc740d13b6600a438
Jenkins Build URL: Acceptance Upstream DXP (master) #1529
ci:test:stable - 9 out of 9 jobs PASSED
9 Successful Jobs:
ci:test:relevant - 23 out of 23 jobs PASSED
23 Successful Jobs:
For more details click here.