Revert "Merge pull request #22 from brave/ttl" #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit a07a84b, reversing
changes made to 7f0c630.
Original issue: #21
Reason of reverting:
#22 would break users who had a device that have been offline for more than 90 days, when that device is back online, it cannot receive updates for items that have been deleted for more than 90 days, so this device will get conflict that it cannot resolve when it tries to change any of those items and keep backoff. It could be reset by leave and rejoin sync chain on this device, but the deleted items in this local will be committed back to server and sync to other devices which might not be what user would want.