Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional Rewards metrics #23833

Merged
merged 1 commit into from
May 31, 2024
Merged

Add additional Rewards metrics #23833

merged 1 commit into from
May 31, 2024

Conversation

DJAndries
Copy link
Collaborator

@DJAndries DJAndries commented May 24, 2024

Resolves brave/brave-browser#38567

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Start with fresh profile, ensure no metrics are present. Enable Rewards.

For Brave.Rewards.AdTypesEnabled.2:

  1. Ensure initial metric value is 7.
  2. Toggle some ad types, ensure metric value is correct.

For Brave.Rewards.SearchResultAdsOptin

  1. Turn off & turn on search ads. Ensure metric does not exist
  2. Turn off search ads and connect a payout account. Ensure metric does not exist
  3. Turn on search ads, ensure metric exists with value 1.

For Brave.Rewards.AdsHistoryView:

View ads history, ensure metric has value 1.

@DJAndries DJAndries requested review from a team as code owners May 24, 2024 20:52
@@ -2223,6 +2234,7 @@ void RewardsServiceImpl::OnP3ADailyTimer() {

void RewardsServiceImpl::OnRecordBackendP3AExternalWallet(
bool delay_report,
bool search_result_optin_changed,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine for now, but if this callback grows any more complex we'll probably want to split it into different callbacks or have this one accept an options struct or an enum value.

@iefremov
Copy link
Contributor

don't we have tests for those? can we add one?

@DJAndries DJAndries merged commit 0582671 into master May 31, 2024
19 checks passed
@DJAndries DJAndries deleted the rewards-more-p3a branch May 31, 2024 18:43
@github-actions github-actions bot added this to the 1.68.x - Nightly milestone May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants