Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(wallet): Always display 'Show Zero Balances' button in Send on iOS #23831

Merged
merged 1 commit into from
May 27, 2024

Conversation

StephenHeaps
Copy link
Collaborator

  • Always show 'Show Zero Balances' button in Select a Token to Send modal. Previously button was only displayed when no displayed tokens had a balance.
  • This applies all networks, but provides extra help with Bitcoin Testnet account when throttled by Bitcoin Testnet network and 0 balance is returned causing account(s) to be hidden so user has to exist Send to copy another Bitcoin Testnet account address

Resolves brave/brave-browser#38452

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Have a wallet with some balance on any network
  2. Open Send and wait for Select a Token to Send modal to load balances
  3. Verify Show Zero Balances button is always displayed. Previously button was only displayed when no displayed tokens had a balance.
Show Zero Balances Hide Zero Balances
Previously in left screenshot, the Show Zero Balances button would not be displayed because other tokens are displayed with a positive balance

…al. Previously button was only displayed when no displayed tokens had a balance.
@StephenHeaps StephenHeaps added CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 labels May 24, 2024
@StephenHeaps StephenHeaps self-assigned this May 24, 2024
@StephenHeaps StephenHeaps requested a review from a team as a code owner May 24, 2024 19:14
@StephenHeaps StephenHeaps merged commit d173f52 into master May 27, 2024
20 checks passed
@StephenHeaps StephenHeaps deleted the wallet/ios-show-zero-balance branch May 27, 2024 17:07
@github-actions github-actions bot added this to the 1.68.x - Nightly milestone May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64
Projects
None yet
2 participants