Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(wallet): Fee icon on Cow Swap confirmation screen is blank on iOS #23830

Merged
merged 4 commits into from
May 27, 2024

Conversation

StephenHeaps
Copy link
Collaborator

Resolves brave/brave-browser#36697

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Submit a swap transaction on swap.cow.fi using Gnosis network (important to use network not preloaded / network without an icon)
  2. Check the panel and verify network icon is not an empty circle.
iOS Desktop (for compare)

… which displays placeholder value when the network image is unavailable. Update `NetworkIcon` placeholder to be Blockie background and remove text overlay. Both changes align with desktop display for consistency.
… WebUI is using `backgroundColor` and `spotColor` for background gradient (used in placeholders), iOS was using `color` & `backgroundColor`. For the seed, aligned to use lowercase for addresses (accounts, assets) but not chain name (Network) or hash (Bitcoin account) to align with WebUI. Renamed `BlockieMaterial` to `BlockieBackground` for clarity.
…previously had no fill which caused 'empty' fee icon).
@StephenHeaps StephenHeaps added CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 labels May 24, 2024
@StephenHeaps StephenHeaps requested a review from nuo-xu May 24, 2024 17:21
@StephenHeaps StephenHeaps self-assigned this May 24, 2024
@StephenHeaps StephenHeaps requested a review from a team as a code owner May 24, 2024 17:21
@StephenHeaps StephenHeaps merged commit 545d128 into master May 27, 2024
20 checks passed
@StephenHeaps StephenHeaps deleted the wallet/cow-swap-network-fee-icon branch May 27, 2024 19:20
@github-actions github-actions bot added this to the 1.68.x - Nightly milestone May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64
Projects
None yet
2 participants