Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade from Chromium 126 to Chromium 127 #23829

Open
wants to merge 156 commits into
base: master
Choose a base branch
from
Open

Upgrade from Chromium 126 to Chromium 127 #23829

wants to merge 156 commits into from
+186,253 −3,210

Conversation

emerick
Copy link
Contributor

@emerick emerick commented May 24, 2024

Resolves brave/brave-browser#38560

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@github-actions github-actions bot added CI/run-network-audit Run network-audit CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) CI/storybook-url Deploy storybook and provide a unique URL for each build CI/run-upstream-tests Run upstream unit and browser tests on Linux and Windows (otherwise only on Linux) feature/web3/wallet feature/web3/wallet/core labels May 24, 2024
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

josheleonard
josheleonard approved these changes Jun 21, 2024
View reviewed changes
Copy link
Collaborator

@josheleonard josheleonard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wallet frontend ++

@emerick emerick mentioned this pull request Jun 21, 2024
Open
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@emerick emerick mentioned this pull request Jun 21, 2024
Open
@emerick
fixup! Make adjustments for upstream tests
823a20f
@emerick
Add RenderViewHostTestEnabler for SplitViewBrowserData unit tests
77a0059 
This avoids the following DCHECK:

  Check failed: instance->IsTestRenderFrameHost(). You may want to instantiate RenderViewHostTestEnabler.
@emerick
fixup! Revert tri-color theme picker to bi-color picker and fix theme…
c33549a 
… colors for tabs
@goodov goodov mentioned this pull request Jun 21, 2024
Open
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

bsclifton
bsclifton approved these changes Jun 21, 2024
View reviewed changes
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

js_deps_reviewers++

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@emerick
fixup! Revert tri-color theme picker to bi-color picker and fix theme…
37b0b89 
… colors for tabs
@emerick
fixup! Avoid static assertion with our negative PageActionIconType va…
78043d6 
…lues
@emerick
Disable syncer::kEnableBookmarkFoldersForAccountStorage
931ccf0 
Disabling this feature flag (which is enabled on iOS and Android by default) for
now as it requires a Google account and possibly other backend support.
@emerick
fixup! Avoid static assertion with our negative PageActionIconType va…
56fa735 
…lues
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylehickinson kylehickinson kylehickinson approved these changes

@github-actions github-actions[bot] github-actions left review comments

@cdesouza-chromium cdesouza-chromium cdesouza-chromium left review comments

@samartnik samartnik samartnik left review comments

@darkdh darkdh darkdh approved these changes

@zenparsing zenparsing zenparsing approved these changes

@thypon thypon thypon left review comments

@bridiver bridiver bridiver left review comments

@deeppandya deeppandya deeppandya approved these changes

@StephenHeaps StephenHeaps StephenHeaps approved these changes

@DJAndries DJAndries DJAndries approved these changes

@goodov goodov goodov approved these changes

@bsclifton bsclifton bsclifton approved these changes

@simonhong simonhong simonhong approved these changes

@iefremov iefremov iefremov approved these changes

@AlexeyBarabash AlexeyBarabash AlexeyBarabash approved these changes

@josheleonard josheleonard josheleonard approved these changes

@tmancey tmancey tmancey approved these changes

@mkarolin mkarolin mkarolin approved these changes

At least 1 approving review is required to merge this pull request.

Assignees

@thypon thypon

@iefremov iefremov

@emerick emerick

@bcaller bcaller

@goodov goodov

@samartnik samartnik

@cdesouza-chromium cdesouza-chromium

Labels
CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) CI/run-network-audit Run network-audit CI/run-upstream-tests Run upstream unit and browser tests on Linux and Windows (otherwise only on Linux) CI/storybook-url Deploy storybook and provide a unique URL for each build feature/web3/wallet/core feature/web3/wallet needs-security-review
Projects
None yet
Milestone
No milestone