Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve linking subscription issues [Uplift to 1.66.x] #23791

Merged
merged 1 commit into from
May 28, 2024
Merged

Resolve linking subscription issues [Uplift to 1.66.x] #23791

merged 1 commit into from
May 28, 2024

Conversation

deeppandya
Copy link
Contributor

@deeppandya deeppandya commented May 22, 2024 •
edited by kjozwiak

Uplift of #23726
Resolves brave/brave-browser#37591

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@deeppandya
Resolve linking subscription issues by changing the way purchase token (
ecb994a 
#23726)

* Resolve linking subscription issues by changing the way purchase token is being saved into local storage

* Resolve presubmit issues related to PR changes
@deeppandya deeppandya added CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS CI/skip-windows-x64 Do not run CI builds for Windows x64 unused-CI/skip-linux-x64 Do not run CI builds for Linux x64 labels May 22, 2024
@deeppandya deeppandya added this to the 1.66.x - Release #3 milestone May 22, 2024
@deeppandya deeppandya self-assigned this May 22, 2024
@deeppandya deeppandya requested a review from a team as a code owner May 22, 2024 19:47
kjozwiak
kjozwiak approved these changes May 28, 2024
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.66.x approved 👍 QA has verified the PR on Nightly using 1.68.x as per #23726 (comment).

@kjozwiak kjozwiak merged commit c38cee7 into 1.66.x May 28, 2024
15 checks passed
@kjozwiak kjozwiak deleted the resolve_linking_subscription_issues_1.66.x branch May 28, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@deeppandya deeppandya

Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 unused-CI/skip-linux-x64 Do not run CI builds for Linux x64
Projects
None yet
Milestone
1.66.x - Release #5
2 participants
@deeppandya @kjozwiak