Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ads] Only load purchase intent resource if the user has joined Brave Rewards and opted-in to notification ads #23788

Closed
wants to merge 1 commit into from

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented May 22, 2024

Resolves brave/brave-browser#38498

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Confirm purchase intent resources are only loaded for users who have joined Brave Rewards and opted in to notification ads

@tmancey tmancey self-assigned this May 22, 2024
@tmancey tmancey requested a review from a team as a code owner May 22, 2024 14:29
@tmancey tmancey enabled auto-merge May 22, 2024 15:01
@tmancey tmancey disabled auto-merge May 22, 2024 17:16
@tmancey tmancey marked this pull request as draft May 22, 2024 22:51
@tmancey
Copy link
Collaborator Author

tmancey commented May 28, 2024

Closing PR as will be resolved by brave/brave-browser#38505

@tmancey tmancey closed this May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants