Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically label issues based on regular expression matches in title and description #23442

Closed
wants to merge 2 commits into from

Conversation

wknapik
Copy link
Collaborator

@wknapik wknapik commented May 6, 2024

This is an implementation based on https://github.com/github/issue-labeler. The action has some quirks, but it's maintained by GitHub and security approved. If we don't like the behavior, we could potentially switch to something else, or even implement our own from scratch.

I added some patterns to start, but the expectation is that people would add more.

Please assign as reviewers and/or tag anyone who should see this and comment.

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@wknapik wknapik added the CI/skip Do not run CI builds (except noplatform) label May 6, 2024
@wknapik wknapik requested a review from bsclifton May 6, 2024 18:57
@wknapik wknapik self-assigned this May 6, 2024
@wknapik wknapik requested a review from a team as a code owner May 6, 2024 18:57
@wknapik wknapik requested review from kjozwiak and rebron May 6, 2024 19:37
@wknapik
Copy link
Collaborator Author

wknapik commented May 6, 2024

Whoops. This needs to go in brave-browser, not brave-core. Closing here, will open in brave-browser.

EDIT: The new PR brave/brave-browser#38107

@wknapik wknapik closed this May 6, 2024
@wknapik wknapik deleted the wknapik-auto-label-issues branch May 6, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip Do not run CI builds (except noplatform)
Projects
None yet
2 participants