Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add actor specific class name #177

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kawikao
Copy link

@kawikao kawikao commented Jun 4, 2017

Allows CSS attributes to override individual actors.

Example to be used in sequence-diagram.css:

.actor0 text {
    fill: blue;
}
.actor0 rect, .actor0 path {
    fill: #9f9;
}
.actor1 rect, .actor1 path {
    fill: #f9f;
}

screen shot 2017-06-04 at 2 48 33 pm

screen shot 2017-06-04 at 2 50 23 pm

@bramp
Copy link
Owner

bramp commented Jun 4, 2017

Very nice idea. Should we use "actorVistor" instead of "actor0"? I guess number based has fewer pitfalls.

I wonder if the CSS nth select would have worked without your change, for example:

.actor rect:nth-child(1), .actor path:nth-child(1) {
    fill: #f9f;
}

Well either way I'll review your changes shortly.

@@ -1498,7 +1498,7 @@ if (typeof Snap != 'undefined') {
drawActor: function(actor, offsetY, height) {
this.beginGroup();
BaseTheme.prototype.drawActor.call(this, actor, offsetY, height);
return this.finishGroup().addClass('actor');
return this.finishGroup().addClass('actor actor'+actor.index);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should make this change in src/theme-snap.js#L231 not in dist/. dist/ is generated from the files in src/, and can be regenerated by running make.

Otherwise LGTM.

@kawikao
Copy link
Author

kawikao commented Jun 4, 2017

I couldn't get .actor:nth-child() or .actor:nth-of-type() to work but I did get it to work with group. One nice side-effect is it's possible to address each box seperately (e.g. top and bottom of the same actor). The downside is having to set both boxes.

Uses group

g:nth-of-type(2) rect

Or a more specific call to group.class

g.actor:nth-of-type(2) rect

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants