refactor: Use email for SSO #1354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ssoVerifySchema in the schema.ts file has been updated to handle both email and slug parameters. The schema now allows for either email or slug to be provided, and at least one of them is required. This change ensures that the ssoVerifySchema can handle different scenarios when verifying SSO information.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
The code changes in `verify.ts` refactor the SSO verification process to improve handling of different scenarios and provide more informative error messages. The `handlePOST` function now uses the `handleTeamSSOVerification` function to handle SSO verification for a given team ID. Additionally, the code now properly handles cases where there are multiple teams with SSO connections and prompts the user to provide a team slug. This refactor ensures a smoother SSO verification experience and better error handling.
This commit refactors the code in `sso.login.spec.ts` to create a new SSO connection for a new team. The `createSSOConnection` function is introduced to handle the process of creating an SSO connection. It takes the page object, team slug, and metadata URL as parameters. The function navigates to the SSO page for the specified team, clicks the "New Connection" button, fills in the metadata URL, saves the connection, and verifies that the connection is visible in the SSO connections table. This refactor improves the readability and maintainability of the code for creating SSO connections.
This commit updates the Playwright configuration for the Chromium project. It adds additional properties to the `use` object, including `baseURL` set to `http://localhost:4002` and `channel` set to `chrome`. It also adds a `port` property to the `webServer` object, set to `4002`. These changes are made to improve the configuration for running tests with Playwright in the Chromium browser.
deepakprabhakara
approved these changes
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.