Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change this to
return result.returncode == 0
this will returnTrue
if the condition meet andFalse
otherwise. If you look at how theinstall
function executes the installer' steps, it checks if one of them returnsFalse
Bottles/bottles/backend/managers/installer.py
Lines 421 to 424 in 2bd8b60
Result
object according to that.Currently, there is no easy way to show a message to the user graphically. It could be possible by making each step returning a tuple (boolean, message) and have the
install
function append that message to the Result object, then updating the installer view in the frontend to use that message if availableBottles/bottles/frontend/windows/installer.py
Lines 165 to 185 in 2bd8b60
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
adding the line
return result.returncode == 0
results in a known failure (exit 1) in the script not even putting a warning in the Console, and just continuing with the rest of the manifest steps.Same goes for adding
return False
or
Bottles just continues on with the rest of the manifest regardless of the failure
It looks like there is something missing to handle the return at this point, as it continues regardless of any state returned