Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): update the link to BCP 47 #7009

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Conversation

xfq
Copy link

@xfq xfq commented Jul 12, 2022

Describe the PR

tools.ietf.org is no longer to be relied on per https://mailarchive.ietf.org/arch/msg/tools-discuss/oYrAxb3KayPzZ4SNB1DVZTDPPNo/

AFAIK, rfc-editor.org is the recommended URL for RFC and BCP nowadays. Also, I changed the link from RFC 5646 to BCP 47 (see https://www.w3.org/TR/international-specs/#lang_bcp_not_rfc ).

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix (fixes a boo-boo in the code) - fix(...), requires a patch version update
  • Feature (adds a new feature to BootstrapVue) - feat(...), requires a minor version update
  • Enhancement (augments an existing feature) - feat(...), requires a minor version update
  • ARIA accessibility (fixes or improves ARIA accessibility) - fix(...), requires a patch or minor version update
  • Documentation update (improves documentation or typo fixes) - chore(docs), requires a patch version update
  • Other (please describe)

Does this PR introduce a breaking change? (check one)

  • No
  • Yes (please describe since breaking changes require a minor version update)

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e. [...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)
  • It should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • The title should follow the Conventional Commits naming convention (i.e. fix(alert): not alerting during SSR render, docs(badge): update pill examples, chore(docs): fix typo in README, etc.). This is very important, as the CHANGELOG is generated from these messages, and determines the next version type (patch or minor).

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates
  • Includes component package.json meta section updates (prop, slot and event changes/updates)
  • Includes any needed TypeScript declaration file updates
  • New/updated tests are included and passing (required for new features and enhancements)
  • Existing test suites are passing
  • CodeCov for patch has met target (all changes/updates have been tested)
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (Does it affect screen reader users or keyboard only users? Clickable items should be in the tab index, etc.)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

@vercel
Copy link

vercel bot commented Jul 12, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
bootstrap-vue ✅ Ready (Inspect) Visit Preview Jan 7, 2023 at 9:48AM (UTC)

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 12, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c60304b:

Sandbox Source
BootstrapVue Starter Project Configuration
BootstrapVue Nuxt.js Starter Project Configuration

@codecov
Copy link

codecov bot commented Jan 7, 2023

Codecov Report

Merging #7009 (c60304b) into dev (3e29c63) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               dev     #7009   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          305       305           
  Lines        10453     10453           
  Branches      2551      2551           
=========================================
  Hits         10453     10453           
Flag Coverage Δ
unittests 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@VividLemon
Copy link
Member

If the recommended standard has changed, then that would assume that there is something on the new that is not supported by bootstrap-vue. You may want to explain a bit more about the scope of what this change is. To clarify, I am fine if this is only a docs change on their part. However, if the spec changed, and we are supposed to be supporting new tags, then linking to some different docs wouldn't be appropriate as it would be misleading.

@xfq
Copy link
Author

xfq commented Jan 24, 2023

This PR just uses the recommended URL of the IETF language tag standard, so if the spec is updated, we don't need to update the URL. This is also the URL recommended by W3C (for many years):

The link to and name of BCP 47 was created specifically so that there is an unchanging reference to the definition of Tags for the Identification of Languages. RFCs 1766, 3066, 4646 were previous (superseded) versions and 5646 is the current version of BCP 47.

In terms of content, RFC 5646 is just the core of BCP 47, so bootstrap-vue doesn't need to update any code. It doesn't introduce new language tags either, because the language subtags are managed by the IANA Subtag Registry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants