fix(Bootstrap): remove deprecated classes #1815
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
VividLemon
requested changes
Mar 15, 2024
dwgray
reviewed
Mar 19, 2024
remove .input-group-append and .input-group-prepend classes update the documentation for BInputGroup
dwgray
reviewed
Apr 2, 2024
|
This PR is stale because it has been open for 45 days with no activity. It will not be auto-closed |
github-actions
bot
added
the
stale
|
@anrolmar @dwgray @VividLemon is this pr still in need of changes? |
VividLemon
reviewed
May 30, 2024
| @@ -67,8 +67,6 @@ Easily extend form controls by adding text, buttons, or button groups on either | |||
|
|
|||
| You can attach addons using either props, named slots and/or sub-components. | |||
|
|
|||
| **Note** Bootstrap 5 dropped `.input-group-append` and `.input-group-prepend`. You can now just add buttons and `.input-group-text` as direct children of the input groups. The sub-components are added for compatibility reasons. | |||
There was a problem hiding this comment.
@xvaara It seems like if this has been dropped, that we could remove the sub-components -- I noticed this the other day, that the two components were exactly the same
There was a problem hiding this comment.
I removed these two components in my feature branch
github-actions
bot
removed
the
stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the PR
This PR remove all the deprecated classes mentioned on #1779 (comment)
PR checklist
What kind of change does this PR introduce? (check at least one)
fix(...)feat(...)fix(...)docs(...)The PR fulfills these requirements:
CHANGELOGis generated from these messages, and determines the next version type. Pull requests that do not follow conventional commits or do not have an override will be denied