Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dladdr minimal support for AIX #114

Merged
merged 2 commits into from
Jun 12, 2024
Merged

Conversation

Helflym
Copy link

@Helflym Helflym commented Nov 4, 2021

AIX doesn't provide dladdr syscall. This patch implements a minimal
version in order to be able to compile stacktrace.

Clément Chigot and others added 2 commits November 4, 2021 13:16
AIX doesn't provide dladdr syscall. This patch implements a minimal
version in order to be able to compile stacktrace.
Copy link
Member

@apolukhin apolukhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've noticed a leak in code, so changed it to store the std::string in Dl_info.

Not quite sure that the result compiles on AIX. Could you please give it a try and propose fixes if something is wrong?

@coveralls
Copy link

Coverage Status

coverage: 86.35% (-7.5%) from 93.865%
when pulling 51807cd on Helflym:develop
into 3f3f902 on boostorg:develop.

@Helflym
Copy link
Author

Helflym commented Jun 11, 2024

Sadly, I won't be able to do so, I don't have access to an AIX server anymore. I propose to let the user behind #89 tests this MR. Otherwise, you can either close it or merge as is hoping it works (the code being solely AIX it would be safe for other targets)

@apolukhin apolukhin merged commit 66c0f7a into boostorg:develop Jun 12, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants