Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

X3: Cover position_tagged's features with test #739

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

denzor200
Copy link

No description provided.

@denzor200 denzor200 closed this Oct 4, 2022
@denzor200 denzor200 reopened this Oct 4, 2022
@Kojoley
Copy link
Collaborator

Kojoley commented Oct 5, 2022

Is there any particular reason for this? I'm pretty sure it is tested indirectly via error handler tests,

I don't have time to deal with CI currently, maybe next week. Probably CI checksout master branch for superrepo on pull requests.

@denzor200
Copy link
Author

I'm pretty sure it is tested indirectly via error handler tests,

I haven't found any references to x3::position_cache in the tests.

Is there any particular reason for this?

position_cache's internals will be patched in #698

@Kojoley
Copy link
Collaborator

Kojoley commented Oct 6, 2022

I'm pretty sure it is tested indirectly via error handler tests,

I haven't found any references to x3::position_cache in the tests.

position_cache<std::vector<Iterator>> pos_cache;

@denzor200
Copy link
Author

I just looked error handler tests. I can't find any test case when x3::error_handler used with parsing into x3::position_tagged attribute. Is it exists?

@denzor200 denzor200 changed the title Cover position_cache with test X3: Cover position_tagged's features with test Oct 12, 2022
@denzor200
Copy link
Author

PR updated. Added test case for x3::error_handler with x3::position_tagged, test case for x3::position_cache was deleted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants