Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow ascii symbols_parser to be matched against unicode chars #655

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

theodelrieu
Copy link
Contributor

@Kojoley

Following up on #649, I inverted the test based on your comment. Let me know what you think about it!

Copy link
Collaborator

@Kojoley Kojoley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My gut feeling tells me that this will open a can of worms, consider this example: BOOST_TEST((!test(U"\U000001613", no_case[foo])))

@theodelrieu
Copy link
Contributor Author

@Kojoley True this can lead to weird stuff like your example.

I'd like to avoid that kind of patches, but right now I don't see how to workaround my problem without writing all my grammars in UTF32.

@theodelrieu
Copy link
Contributor Author

@djowel What do you think about this one?

@djowel
Copy link
Member

djowel commented Mar 5, 2021

I can understand @Kojoley's concern. I'm uneasy with it as well, but I do not have an easy solution ATM. Perhaps if you can start with a simple mvce use-case, we can find something that can work better. I'm thinking something explicit, rather than implicit.

@theodelrieu
Copy link
Contributor Author

Understood, I will try to come up with a MCVE later this month.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants