Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stats per function call to Function Chart (GUI) #139

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

jkunstwald
Copy link
Contributor

@jkunstwald jkunstwald commented Sep 17, 2021

Optick PR

  • Add per-call min, max, average and std dev times to the function chart window
    • Values min/maxed/avgd across calls, not frames, unlike the existing ones
  • Clarified the tooltips for the existing averages ("Average Time" -> "Time spent in this function during an average frame")
  • Precompute all these stats including the existing AvgTotal, AvgWait, AvgWork during load instead of in the getters

Not sure if this is a good idea or if you want the values to be somewhere else, i required this feature personally. The performance impact is minimal now that the values are precomputed, in fact this is likely a flat improvement over the current version even though more things are computed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant