feat(console): reuse deno console's impl #3468
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request reuses deno's console implementation with the following changes:
The testing use a hacky solution by overriding __boa_print and __boa_no_color to store colorless output into the property __hack_print_output of a global object.
An odd problem occurs when attempting to output an array containing Chinese characters using
console.log(['你', '好'])
. However, the code runs successfully if the join() function is used before the output:console.log(['你', '好'].join())
. I don't know how to fix this...