fix #ISSUE-49 #50
Open
fix #ISSUE-49 #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ememisya
force-pushed
the
ISSUE-49
branch
2 times, most recently
from
0aeeb88
to
7d5db26
Compare
ememisya
commented
Jan 25, 2024
| startCaptureVariable + captureVariable.length(), | ||
| "' + encodeURIComponent(" + pathVariableName + ") + '"); | ||
| } else { | ||
| validatePathVariableParameter(pathStringBuilder, pathVariableName, -1); |
There was a problem hiding this comment.
I left this here since I wasn't sure what you wanted to do with this method for any future reference.
ememisya
commented
Jan 25, 2024
| stripPatternParserFeatures(pathStringBuilder, 0); | ||
| } | ||
|
|
||
| protected static void stripPatternParserFeatures(StringBuilder pathStringBuilder, int fromIndex) |
There was a problem hiding this comment.
I didn't simply call this strip RegexPattern because again I am not certain what Spring wanted to do with this. It is possible perhaps that they may add some sort of SpEL expression feature here in the future, not sure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve by removing the PathPattern features until implementation can be supported.