Implement @bloomberg/babel-plugin-polyfill-record-tuple
#50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolo-ribaudo
commented
Dec 29, 2020
| @@ -0,0 +1,3 @@ | |||
| import { parseImmutable as _parseImmutable } from "@bloomberg/polyfill-record-tuple"; | |||
There was a problem hiding this comment.
This is not really pure, it stills define JSON.parseImmutable = .... Imo the polyfill should support another entry point that doesn't define the globals but just exports them.
|
@nicolo-ribaudo do we still want to pursue this? If yes, we should rebase and remove references to Box. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
We provide to polyfill authors the tools to implement their own Babel plugin to inject polyfills (similarly to what Babel does with
core-js): https://github.com/babel/babel-polyfillsThis is different from how the it is done in the syntax transform plugin, because this new plugin aims to give support for direct usage of the new built-ins rather than to the new syntax.
Since we didn't discuss about this, feel free to close if you think it's out of scope.
Testing performed
Tests added