Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event Context #1383

Merged
merged 40 commits into from
May 30, 2024
Merged

Event Context #1383

merged 40 commits into from
May 30, 2024

Conversation

TheTechromancer
Copy link
Collaborator

@TheTechromancer TheTechromancer commented May 16, 2024

The main feature of this PR is a new attribute on every event: discovery_context. This contains a human-friendly description of exactly how the data was discovered, including any nuanced circumstances around its creation.

For convenience, a discovery_path attribute has been added (to JSON and CSV outputs) that contains the full discovery chain from the scan target all the way to the current event.

Also, the event .source attribute has been renamed to .parent for clarity.

TODO:

  • speculate
  • excavate
  • DNS resolution
  • code-enum family (especially postman)
  • dehashed
  • massdns
  • bucket modules

@codecov-commenter
Copy link

codecov-commenter commented May 17, 2024

Codecov Report

Attention: Patch coverage is 95.45455% with 34 lines in your changes are missing coverage. Please review.

Project coverage is 92%. Comparing base (1691332) to head (325d2ed).
Report is 27 commits behind head on bbot-2.0.

Current head 325d2ed differs from pull request most recent head 79c59ed

Please upload reports for the commit 79c59ed to get more accurate results.

Files Patch % Lines
bbot/modules/portscan.py 42% 7 Missing ⚠️
bbot/modules/internal/excavate.py 74% 4 Missing ⚠️
bbot/core/event/base.py 97% 3 Missing ⚠️
bbot/modules/output/asset_inventory.py 50% 3 Missing ⚠️
bbot/modules/deadly/nuclei.py 50% 2 Missing ⚠️
bbot/modules/dnsbrute_mutations.py 85% 2 Missing ⚠️
bbot/modules/fingerprintx.py 82% 2 Missing ⚠️
bbot/modules/skymem.py 89% 2 Missing ⚠️
bbot/modules/sslcert.py 67% 2 Missing ⚠️
bbot/modules/templates/bucket.py 72% 2 Missing ⚠️
... and 5 more
Additional details and impacted files
@@            Coverage Diff            @@
##           bbot-2.0   #1383    +/-   ##
=========================================
- Coverage        92%     92%    -0%     
=========================================
  Files           340     340            
  Lines         23048   23295   +247     
=========================================
+ Hits          21150   21370   +220     
- Misses         1898    1925    +27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TheTechromancer TheTechromancer mentioned this pull request May 23, 2024
48 tasks
@TheTechromancer TheTechromancer self-assigned this May 24, 2024
@TheTechromancer TheTechromancer merged commit 707bb3a into bbot-2.0 May 30, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants