feat(helm): update chart node-feature-discovery to 0.16.0 #3369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![bot-x-mod[bot]](https://avatars.githubusercontent.com/in/315222?s=60&v=4){kind=small}
--- HelmRelease: kube-system/node-feature-discovery ConfigMap: kube-system/node-feature-discovery-topology-updater-conf
+++ HelmRelease: kube-system/node-feature-discovery ConfigMap: kube-system/node-feature-discovery-topology-updater-conf
@@ -1,13 +0,0 @@
----
-apiVersion: v1
-kind: ConfigMap
-metadata:
- name: node-feature-discovery-topology-updater-conf
- namespace: kube-system
- labels:
- app.kubernetes.io/name: node-feature-discovery
- app.kubernetes.io/instance: node-feature-discovery
- app.kubernetes.io/managed-by: Helm
-data:
- nfd-topology-updater.conf: 'null'
-
--- HelmRelease: kube-system/node-feature-discovery ClusterRole: kube-system/node-feature-discovery
+++ HelmRelease: kube-system/node-feature-discovery ClusterRole: kube-system/node-feature-discovery
@@ -20,16 +20,24 @@
- list
- apiGroups:
- nfd.k8s-sigs.io
resources:
- nodefeatures
- nodefeaturerules
+ - nodefeaturegroups
verbs:
- get
- list
- watch
+- apiGroups:
+ - nfd.k8s-sigs.io
+ resources:
+ - nodefeaturegroups/status
+ verbs:
+ - patch
+ - update
- apiGroups:
- coordination.k8s.io
resources:
- leases
verbs:
- create
--- HelmRelease: kube-system/node-feature-discovery DaemonSet: kube-system/node-feature-discovery-worker
+++ HelmRelease: kube-system/node-feature-discovery DaemonSet: kube-system/node-feature-discovery-worker
@@ -31,14 +31,25 @@
allowPrivilegeEscalation: false
capabilities:
drop:
- ALL
readOnlyRootFilesystem: true
runAsNonRoot: true
- image: registry.k8s.io/nfd/node-feature-discovery:v0.15.1
+ image: registry.k8s.io/nfd/node-feature-discovery:v0.16.0
imagePullPolicy: IfNotPresent
+ livenessProbe:
+ grpc:
+ port: 8082
+ initialDelaySeconds: 10
+ periodSeconds: 10
+ readinessProbe:
+ grpc:
+ port: 8082
+ initialDelaySeconds: 5
+ periodSeconds: 10
+ failureThreshold: 10
env:
- name: NODE_NAME
valueFrom:
fieldRef:
fieldPath: spec.nodeName
- name: POD_NAME
@@ -46,16 +57,24 @@
fieldRef:
fieldPath: metadata.name
- name: POD_UID
valueFrom:
fieldRef:
fieldPath: metadata.uid
- resources: {}
+ resources:
+ limits:
+ cpu: 200m
+ memory: 512Mi
+ requests:
+ cpu: 5m
+ memory: 64Mi
command:
- nfd-worker
args:
+ - -feature-gates=NodeFeatureAPI=true
+ - -feature-gates=NodeFeatureGroupAPI=false
- -metrics=8081
ports:
- name: metrics
containerPort: 8081
volumeMounts:
- name: host-boot
@@ -69,12 +88,15 @@
readOnly: true
- name: host-usr-lib
mountPath: /host-usr/lib
readOnly: true
- name: host-lib
mountPath: /host-lib
+ readOnly: true
+ - name: host-proc-swaps
+ mountPath: /host-proc/swaps
readOnly: true
- name: source-d
mountPath: /etc/kubernetes/node-feature-discovery/source.d/
readOnly: true
- name: features-d
mountPath: /etc/kubernetes/node-feature-discovery/features.d/
@@ -95,12 +117,15 @@
- name: host-usr-lib
hostPath:
path: /usr/lib
- name: host-lib
hostPath:
path: /lib
+ - name: host-proc-swaps
+ hostPath:
+ path: /proc/swaps
- name: source-d
hostPath:
path: /etc/kubernetes/node-feature-discovery/source.d/
- name: features-d
hostPath:
path: /etc/kubernetes/node-feature-discovery/features.d/
--- HelmRelease: kube-system/node-feature-discovery Deployment: kube-system/node-feature-discovery-master
+++ HelmRelease: kube-system/node-feature-discovery Deployment: kube-system/node-feature-discovery-master
@@ -32,22 +32,22 @@
allowPrivilegeEscalation: false
capabilities:
drop:
- ALL
readOnlyRootFilesystem: true
runAsNonRoot: true
- image: registry.k8s.io/nfd/node-feature-discovery:v0.15.1
+ image: registry.k8s.io/nfd/node-feature-discovery:v0.16.0
imagePullPolicy: IfNotPresent
livenessProbe:
grpc:
- port: 8080
+ port: 8082
initialDelaySeconds: 10
periodSeconds: 10
readinessProbe:
grpc:
- port: 8080
+ port: 8082
initialDelaySeconds: 5
periodSeconds: 10
failureThreshold: 10
ports:
- containerPort: 8080
name: grpc
@@ -57,15 +57,23 @@
- name: NODE_NAME
valueFrom:
fieldRef:
fieldPath: spec.nodeName
command:
- nfd-master
- resources: {}
+ resources:
+ limits:
+ cpu: 300m
+ memory: 4Gi
+ requests:
+ cpu: 100m
+ memory: 128Mi
args:
- -crd-controller=true
+ - -feature-gates=NodeFeatureAPI=true
+ - -feature-gates=NodeFeatureGroupAPI=false
- -metrics=8081
volumeMounts:
- name: nfd-master-conf
mountPath: /etc/kubernetes/node-feature-discovery
readOnly: true
volumes:
--- HelmRelease: kube-system/node-feature-discovery Deployment: kube-system/node-feature-discovery-gc
+++ HelmRelease: kube-system/node-feature-discovery Deployment: kube-system/node-feature-discovery-gc
@@ -25,24 +25,30 @@
spec:
serviceAccountName: node-feature-discovery-gc
dnsPolicy: ClusterFirstWithHostNet
securityContext: {}
containers:
- name: gc
- image: registry.k8s.io/nfd/node-feature-discovery:v0.15.1
+ image: registry.k8s.io/nfd/node-feature-discovery:v0.16.0
imagePullPolicy: IfNotPresent
env:
- name: NODE_NAME
valueFrom:
fieldRef:
fieldPath: spec.nodeName
command:
- nfd-gc
args:
- -gc-interval=1h
- resources: {}
+ resources:
+ limits:
+ cpu: 20m
+ memory: 1Gi
+ requests:
+ cpu: 10m
+ memory: 128Mi
securityContext:
allowPrivilegeEscalation: false
capabilities:
drop:
- ALL
readOnlyRootFilesystem: true
--- HelmRelease: kube-system/node-feature-discovery ServiceAccount: kube-system/node-feature-discovery-prune
+++ HelmRelease: kube-system/node-feature-discovery ServiceAccount: kube-system/node-feature-discovery-prune
@@ -0,0 +1,14 @@
+---
+apiVersion: v1
+kind: ServiceAccount
+metadata:
+ name: node-feature-discovery-prune
+ namespace: kube-system
+ labels:
+ app.kubernetes.io/name: node-feature-discovery
+ app.kubernetes.io/instance: node-feature-discovery
+ app.kubernetes.io/managed-by: Helm
+ annotations:
+ helm.sh/hook: post-delete
+ helm.sh/hook-delete-policy: before-hook-creation,hook-succeeded
+
--- HelmRelease: kube-system/node-feature-discovery ClusterRole: kube-system/node-feature-discovery-prune
+++ HelmRelease: kube-system/node-feature-discovery ClusterRole: kube-system/node-feature-discovery-prune
@@ -0,0 +1,24 @@
+---
+apiVersion: rbac.authorization.k8s.io/v1
+kind: ClusterRole
+metadata:
+ name: node-feature-discovery-prune
+ labels:
+ app.kubernetes.io/name: node-feature-discovery
+ app.kubernetes.io/instance: node-feature-discovery
+ app.kubernetes.io/managed-by: Helm
+ annotations:
+ helm.sh/hook: post-delete
+ helm.sh/hook-delete-policy: before-hook-creation,hook-succeeded
+rules:
+- apiGroups:
+ - ''
+ resources:
+ - nodes
+ - nodes/status
+ verbs:
+ - get
+ - patch
+ - update
+ - list
+
--- HelmRelease: kube-system/node-feature-discovery ClusterRoleBinding: kube-system/node-feature-discovery-prune
+++ HelmRelease: kube-system/node-feature-discovery ClusterRoleBinding: kube-system/node-feature-discovery-prune
@@ -0,0 +1,21 @@
+---
+apiVersion: rbac.authorization.k8s.io/v1
+kind: ClusterRoleBinding
+metadata:
+ name: node-feature-discovery-prune
+ labels:
+ app.kubernetes.io/name: node-feature-discovery
+ app.kubernetes.io/instance: node-feature-discovery
+ app.kubernetes.io/managed-by: Helm
+ annotations:
+ helm.sh/hook: post-delete
+ helm.sh/hook-delete-policy: before-hook-creation,hook-succeeded
+roleRef:
+ apiGroup: rbac.authorization.k8s.io
+ kind: ClusterRole
+ name: node-feature-discovery-prune
+subjects:
+- kind: ServiceAccount
+ name: node-feature-discovery-prune
+ namespace: kube-system
+
--- HelmRelease: kube-system/node-feature-discovery Job: kube-system/node-feature-discovery-prune
+++ HelmRelease: kube-system/node-feature-discovery Job: kube-system/node-feature-discovery-prune
@@ -0,0 +1,66 @@
+---
+apiVersion: batch/v1
+kind: Job
+metadata:
+ name: node-feature-discovery-prune
+ namespace: kube-system
+ labels:
+ app.kubernetes.io/name: node-feature-discovery
+ app.kubernetes.io/instance: node-feature-discovery
+ app.kubernetes.io/managed-by: Helm
+ annotations:
+ helm.sh/hook: post-delete
+ helm.sh/hook-delete-policy: before-hook-creation,hook-succeeded
+spec:
+ template:
+ metadata:
+ labels:
+ app.kubernetes.io/name: node-feature-discovery
+ app.kubernetes.io/instance: node-feature-discovery
+ app.kubernetes.io/managed-by: Helm
+ role: prune
+ spec:
+ serviceAccountName: node-feature-discovery-prune
+ containers:
+ - name: nfd-master
+ securityContext:
+ allowPrivilegeEscalation: false
+ capabilities:
+ drop:
+ - ALL
+ readOnlyRootFilesystem: true
+ runAsNonRoot: true
+ image: registry.k8s.io/nfd/node-feature-discovery:v0.16.0
+ imagePullPolicy: IfNotPresent
+ command:
+ - nfd-master
+ args:
+ - -prune
+ restartPolicy: Never
+ affinity:
+ nodeAffinity:
+ preferredDuringSchedulingIgnoredDuringExecution:
+ - preference:
+ matchExpressions:
+ - key: node-role.kubernetes.io/master
+ operator: In
+ values:
+ - ''
+ weight: 1
+ - preference:
+ matchExpressions:
+ - key: node-role.kubernetes.io/control-plane
+ operator: In
+ values:
+ - ''
+ weight: 1
+ tolerations:
+ - effect: NoSchedule
+ key: node-role.kubernetes.io/master
+ operator: Equal
+ value: ''
+ - effect: NoSchedule
+ key: node-role.kubernetes.io/control-plane
+ operator: Equal
+ value: ''
+ |
--- kubernetes/main/apps/kube-system/node-feature-discovery/app Kustomization: flux-system/node-feature-discovery HelmRelease: kube-system/node-feature-discovery
+++ kubernetes/main/apps/kube-system/node-feature-discovery/app Kustomization: flux-system/node-feature-discovery HelmRelease: kube-system/node-feature-discovery
@@ -13,13 +13,13 @@
spec:
chart: node-feature-discovery
sourceRef:
kind: HelmRepository
name: node-feature-discovery
namespace: flux-system
- version: 0.15.1
+ version: 0.16.0
install:
crds: CreateReplace
remediation:
retries: 3
interval: 30m
maxHistory: 2 |
bot-x-mod
bot
changed the title
bot-x-mod
bot
force-pushed
the
renovate/main-node-feature-discovery-0.x
branch
from
19b97a8
to
3bc2972
Compare
bot-x-mod
bot
force-pushed
the
renovate/main-node-feature-discovery-0.x
branch
from
3bc2972
to
83ce3c3
Compare
bot-x-mod
bot
changed the title
bot-x-mod
bot
force-pushed
the
renovate/main-node-feature-discovery-0.x
branch
from
83ce3c3
to
a32ffc1
Compare
bot-x-mod
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
0.15.1->0.16.0Warning
Some dependencies could not be looked up. Check the Dependency Dashboard for more information.
Release Notes
kubernetes-sigs/node-feature-discovery (node-feature-discovery)
v0.16.0: v0.16Compare Source
Changelog
NodeFeatureGroup API
The NodeFeatureGroup custom resource was added to the NFD API. The NodeFeatureGroup API enables the creation of node groups based on features discovered by NFD. The API is an alpha feature and is disabled by default and can be enabled with the NodeFeatureGroupAPI feature gate.
See documentation for more details.
Feature gates
NFD adapted the concept of feature gates from Kubernetes to introduce and stabilize new features in a controlled way. See the documentation for more details. Two existing features (NodeFeature API and disabling label auto-prefixing) were converted into feature gates.
Deprecations
Upcoming changes
Support for hooks is deprecated since v0.12.0 and will be completely dropped in the NFD v0.17.
RDT feature labels removed
The
feature.node.kubernetes.io/cpu-rdt.*feature labels that were deprecated in NFD v0.13 were removed. RDT features are still available for use in NodeFeatureRules for custom labels.Deprecated flags and options
The autoDefaultNs config file option of nfd-master is deprecated and will be removed in NFD v0.17. Superseded by the DisableAutoPrefix feature gate (
featureGates.DisableAutoPrefixHelm parameter).The
-enable-nodefeature-apicommand line flag of nfd-master and nfd-worker and the correspondingenableNodeFeatureApiHelm chart parameter have been deprecated and will be removed in NFD v0.17. Superseded by the NodeFeature API feature gate (featureGates.NodeFeatureAPIHelm parameter).The
-crd-controllercommand line flag of nfd-master is deprecated and will be removed with the gRPC API in a future release.Miscellaneous
Network devices
Discover speed of virtual network interfaces.
DMI
Added support for detecting DMI attributes from
/sys/devices/virtual/dmi/id/. In v0.16 onlysys_vendordiscovered, available assystem.dmiid.sys_vendorfeature for use in NodeFeatureRules.Swap
Discover the availability of swap on the node. Available as
memory.swap.enabledfeature for use in NodeFeatureRules.Helm chart
Now all nodes are cleaned up (feature labels, annotations, extended resources and taints are removed) after uninstalling NFD using a post-delete hook.
The Helm chart now sets resource requests (cpu and memory) for NFD pods. Users may want to adjust these for their cluster. An option to set the pod priority class was added. See Helm chart parameters in the documentation).
Container health
A gRPC health server was added to the nfd-master, nfd-worker and nfd-topology-updater daemons. Deployments (Helm and kustomize) configure container liveness and readiness probes to use that for health checking.
List of PRs
nfd-workererroring when reading attributes from paravirtual devices (#1557)v0.15.4Compare Source
This patch release fixes a potential crash in nfd-master (#1644).
v0.15.3Compare Source
Changelog
This patch release fixes a critical memory leak in nfd-master, along with updating dependencies.
Full Changelog: kubernetes-sigs/node-feature-discovery@v0.15.2...v0.15.3
v0.15.2Compare Source
Changelog
This release fixes a bug in hooks and updates dependencies.
Full Changelog: kubernetes-sigs/node-feature-discovery@v0.15.1...v0.15.2
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Renovate Bot.