Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AC-2088] Fix migration script date to be merge date #4028

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

eliykat
Copy link
Member

@eliykat eliykat commented Apr 29, 2024

Type of change

- [x] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

I merged #3934 without updating the date of the migration script. This meant that migrations are now out of order and do not match the date they were merged. In this case I do not see it causing any issue, however it is a mistake that I think we should fix.

Code changes

  • file.ext: Description of what was changed and why

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • If making database changes - make sure you also update Entity Framework queries and/or migrations
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

@eliykat eliykat requested a review from a team as a code owner April 29, 2024 01:08
@eliykat eliykat enabled auto-merge (squash) April 29, 2024 01:10
Copy link

codecov bot commented Apr 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 38.13%. Comparing base (ba36b2d) to head (d135eb8).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4028   +/-   ##
=======================================
  Coverage   38.13%   38.13%           
=======================================
  Files        1195     1195           
  Lines       58194    58194           
  Branches     5576     5576           
=======================================
  Hits        22192    22192           
- Misses      34956    34957    +1     
+ Partials     1046     1045    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details582c43cd-4a88-4f02-bb83-9199df8fd624

No New Or Fixed Issues Found

@eliykat eliykat merged commit 1921767 into main Apr 29, 2024
52 checks passed
@eliykat eliykat deleted the ac/ac-2088/bump-migration-script-date branch April 29, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants